From 7498d604be92a0b1a7a5603e0295f194aa8b05e7 Mon Sep 17 00:00:00 2001 From: Kamen Mladenov Date: Fri, 4 Apr 2025 10:59:34 +0300 Subject: fix(zkvms/zkm): Update SDK and remove hack Recently ZKM introduced a bug, where SNARK_SETUP would crash, but the witness would be generated. So we introduced a hack where we would run SNARK_SETUP, ignore the crash and rerun the program again, without SNARK_SETUP. Now they fixed it, so with SNARK_SETUP, the witnesses would be generated and the proving process will be done directly after. --- zkvms/zkm/default.nix | 4 +--- zkvms/zkm/host/Cargo.lock | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'zkvms/zkm') diff --git a/zkvms/zkm/default.nix b/zkvms/zkm/default.nix index d7df33a..11d6f12 100644 --- a/zkvms/zkm/default.nix +++ b/zkvms/zkm/default.nix @@ -38,9 +38,7 @@ in zkvmLib.buildPackage craneLib (commonArgs // { preRun = '' export ELF_PATH="$out/bin/guest" export PKG_CONFIG_PATH='${openssl.dev}/lib/pkgconfig' # Dirty hack - - echo "Generating witness. THIS COULD RETURN A SIGSEGV ERROR, IGNORE IT" - SNARK_SETUP=true "$out"/bin/host-${commonArgs.pname} prove 2>/dev/null || true + export SNARK_SETUP="\''${SNARK_SETUP-true}" ''; doCheck = false; diff --git a/zkvms/zkm/host/Cargo.lock b/zkvms/zkm/host/Cargo.lock index b8371eb..bcc5269 100644 --- a/zkvms/zkm/host/Cargo.lock +++ b/zkvms/zkm/host/Cargo.lock @@ -2588,9 +2588,9 @@ checksum = "6877bb514081ee2a7ff5ef9de3281f14a4dd4bceac4c09388074a6b5df8a139a" [[package]] name = "miniz_oxide" -version = "0.8.5" +version = "0.8.7" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8e3e04debbb59698c15bacbb6d93584a8c0ca9cc3213cb423d31f760d8843ce5" +checksum = "ff70ce3e48ae43fa075863cef62e8b43b71a4f2382229920e0df362592919430" dependencies = [ "adler2", ] @@ -5477,7 +5477,7 @@ dependencies = [ [[package]] name = "zkm-sdk" version = "0.2.0" -source = "git+https://github.com/zkMIPS/zkm-project-template#6d878d0eb39c564ff2a79da941a16d6b3409ba05" +source = "git+https://github.com/zkMIPS/zkm-project-template#339e6c793194653e04d2f52b15e497758e4877df" dependencies = [ "anyhow", "async-trait", -- cgit v1.2.3