From 5372fa5e7cd1a3d97a61052cd87f2105c65b143a Mon Sep 17 00:00:00 2001 From: Syndamia Date: Sun, 14 Mar 2021 11:39:23 +0200 Subject: Updated code style of mock setups in Service layer tests --- .../DevHive.Services.Tests/UserService.Tests.cs | 180 +++++++++++---------- 1 file changed, 92 insertions(+), 88 deletions(-) (limited to 'src/Services/DevHive.Services.Tests/UserService.Tests.cs') diff --git a/src/Services/DevHive.Services.Tests/UserService.Tests.cs b/src/Services/DevHive.Services.Tests/UserService.Tests.cs index 58ee223..809e83b 100644 --- a/src/Services/DevHive.Services.Tests/UserService.Tests.cs +++ b/src/Services/DevHive.Services.Tests/UserService.Tests.cs @@ -65,18 +65,20 @@ namespace DevHive.Services.Tests UserName = "g_trapov" }; - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); - this._userRepositoryMock.Setup(p => - p.VerifyPassword(It.IsAny(), It.IsAny())) - .Returns(Task.FromResult(true)); - this._userRepositoryMock.Setup(p => - p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.VerifyPassword(It.IsAny(), It.IsAny())) + .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.GetByUsernameAsync(It.IsAny())) + .Returns(Task.FromResult(user)); string jwtSecurityToken = "akjdhfakndvlahdfkljahdlfkjhasldf"; - this._jwtServiceMock.Setup(p => p.GenerateJwtToken(It.IsAny(), It.IsAny(), It.IsAny>())).Returns(jwtSecurityToken); + this._jwtServiceMock + .Setup(p => p.GenerateJwtToken(It.IsAny(), It.IsAny(), It.IsAny>())) + .Returns(jwtSecurityToken); TokenModel tokenModel = await this._userService.LoginUser(loginServiceModel); Assert.AreEqual(jwtSecurityToken, tokenModel.Token, "LoginUser does not return the correct token"); @@ -87,9 +89,9 @@ namespace DevHive.Services.Tests { LoginServiceModel loginServiceModel = new(); - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); Exception ex = Assert.ThrowsAsync( () => this._userService.LoginUser(loginServiceModel)); @@ -111,12 +113,12 @@ namespace DevHive.Services.Tests Id = Guid.NewGuid(), }; - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); - this._userRepositoryMock.Setup(p => - p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.GetByUsernameAsync(It.IsAny())) + .Returns(Task.FromResult(user)); Exception ex = Assert.ThrowsAsync(() => this._userService.LoginUser(loginServiceModel)); @@ -140,38 +142,40 @@ namespace DevHive.Services.Tests }; Role role = new() { Name = Role.DefaultRole }; - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); - this._userRepositoryMock.Setup(p => - p.VerifyPassword(It.IsAny(), It.IsAny())) - .Returns(Task.FromResult(true)); - this._userRepositoryMock.Setup(p => - p.DoesEmailExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); - this._userRepositoryMock.Setup(p => - p.AddAsync(It.IsAny())) - .ReturnsAsync(true); - this._userRepositoryMock.Setup(p => - p.AddRoleToUser(It.IsAny(), It.IsAny())) - .ReturnsAsync(true); - this._userRepositoryMock.Setup(p => - p.GetByUsernameAsync(It.IsAny())) - .ReturnsAsync(user); - - this._roleRepositoryMock.Setup(p => - p.DoesNameExist(It.IsAny())) - .Returns(Task.FromResult(true)); - this._roleRepositoryMock.Setup(p => - p.GetByNameAsync(It.IsAny())) - .Returns(Task.FromResult(role)); - - this._mapperMock.Setup(p => - p.Map(It.IsAny())) - .Returns(user); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.VerifyPassword(It.IsAny(), It.IsAny())) + .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.DoesEmailExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.AddAsync(It.IsAny())) + .ReturnsAsync(true); + this._userRepositoryMock + .Setup(p => p.AddRoleToUser(It.IsAny(), It.IsAny())) + .ReturnsAsync(true); + this._userRepositoryMock + .Setup(p => p.GetByUsernameAsync(It.IsAny())) + .ReturnsAsync(user); + + this._roleRepositoryMock + .Setup(p => p.DoesNameExist(It.IsAny())) + .Returns(Task.FromResult(true)); + this._roleRepositoryMock + .Setup(p => p.GetByNameAsync(It.IsAny())) + .Returns(Task.FromResult(role)); + + this._mapperMock + .Setup(p => p.Map(It.IsAny())) + .Returns(user); string jwtSecurityToken = "akjdhfakndvlahdfkljahdlfkjhasldf"; - this._jwtServiceMock.Setup(p => p.GenerateJwtToken(It.IsAny(), It.IsAny(), It.IsAny>())).Returns(jwtSecurityToken); + this._jwtServiceMock + .Setup(p => p.GenerateJwtToken(It.IsAny(), It.IsAny(), It.IsAny>())) + .Returns(jwtSecurityToken); TokenModel tokenModel = await this._userService.RegisterUser(registerServiceModel); Assert.AreEqual(jwtSecurityToken, tokenModel.Token, "RegisterUser does not return the correct token"); @@ -183,9 +187,9 @@ namespace DevHive.Services.Tests const string EXCEPTION_MESSAGE = "Username already exists!"; RegisterServiceModel registerServiceModel = new(); - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); Exception ex = Assert.ThrowsAsync( () => this._userService.RegisterUser(registerServiceModel)); @@ -198,12 +202,12 @@ namespace DevHive.Services.Tests { RegisterServiceModel registerServiceModel = new(); - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); - this._userRepositoryMock.Setup(p => - p.DoesEmailExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.DoesEmailExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); Exception ex = Assert.ThrowsAsync(() => this._userService.RegisterUser(registerServiceModel)); @@ -223,12 +227,12 @@ namespace DevHive.Services.Tests UserName = username }; - this._userRepositoryMock.Setup(p => - p.GetByIdAsync(It.IsAny())) - .Returns(Task.FromResult(user)); - this._mapperMock.Setup(p => - p.Map(It.IsAny())) - .Returns(userServiceModel); + this._userRepositoryMock + .Setup(p => p.GetByIdAsync(It.IsAny())) + .Returns(Task.FromResult(user)); + this._mapperMock + .Setup(p => p.Map(It.IsAny())) + .Returns(userServiceModel); UserServiceModel result = await this._userService.GetUserById(id); @@ -239,9 +243,9 @@ namespace DevHive.Services.Tests public void GetTechnologyById_ThrowsException_WhenTechnologyDoesNotExist() { Guid id = new(); - this._userRepositoryMock.Setup(p => - p.GetByIdAsync(It.IsAny())) - .Returns(Task.FromResult(null)); + this._userRepositoryMock + .Setup(p => p.GetByIdAsync(It.IsAny())) + .Returns(Task.FromResult(null)); Exception ex = Assert.ThrowsAsync(() => this._userService.GetUserById(id)); @@ -260,12 +264,12 @@ namespace DevHive.Services.Tests UserName = username }; - this._userRepositoryMock.Setup(p => - p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); - this._mapperMock.Setup(p => - p.Map(It.IsAny())) - .Returns(userServiceModel); + this._userRepositoryMock + .Setup(p => p.GetByUsernameAsync(It.IsAny())) + .Returns(Task.FromResult(user)); + this._mapperMock + .Setup(p => p.Map(It.IsAny())) + .Returns(userServiceModel); UserServiceModel result = await this._userService.GetUserByUsername(username); @@ -277,9 +281,9 @@ namespace DevHive.Services.Tests { string username = "g_trapov"; - this._userRepositoryMock.Setup(p => - p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(null)); + this._userRepositoryMock + .Setup(p => p.GetByUsernameAsync(It.IsAny())) + .Returns(Task.FromResult(null)); Exception ex = Assert.ThrowsAsync(() => this._userService.GetUserByUsername(username)); @@ -353,9 +357,9 @@ namespace DevHive.Services.Tests { UpdateUserServiceModel updateUserServiceModel = new(); - this._userRepositoryMock.Setup(p => - p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.DoesUserExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel)); @@ -367,12 +371,12 @@ namespace DevHive.Services.Tests { UpdateUserServiceModel updateUserServiceModel = new(); - this._userRepositoryMock.Setup(p => - p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); - this._userRepositoryMock.Setup(p => - p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.DoesUserExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); + this._userRepositoryMock + .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) + .Returns(Task.FromResult(true)); Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel)); @@ -411,9 +415,9 @@ namespace DevHive.Services.Tests string exceptionMessage = "User does not exist!"; Guid id = new(); - this._userRepositoryMock.Setup(p => - p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + this._userRepositoryMock + .Setup(p => p.DoesUserExistAsync(It.IsAny())) + .Returns(Task.FromResult(false)); Exception ex = Assert.ThrowsAsync(() => this._userService.DeleteUser(id)); -- cgit v1.2.3