From 10ac1adbf9fbeaca116d3fd356f85dd64c8c2bf8 Mon Sep 17 00:00:00 2001 From: Syndamia Date: Sun, 14 Mar 2021 12:02:14 +0200 Subject: Made all Returns(Task.FromResult) into ReturnsAsync in Service layer tests --- .../DevHive.Services.Tests/UserService.Tests.cs | 56 +++++++++++----------- 1 file changed, 28 insertions(+), 28 deletions(-) (limited to 'src/Services/DevHive.Services.Tests/UserService.Tests.cs') diff --git a/src/Services/DevHive.Services.Tests/UserService.Tests.cs b/src/Services/DevHive.Services.Tests/UserService.Tests.cs index 809e83b..7990b32 100644 --- a/src/Services/DevHive.Services.Tests/UserService.Tests.cs +++ b/src/Services/DevHive.Services.Tests/UserService.Tests.cs @@ -67,13 +67,13 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._userRepositoryMock .Setup(p => p.VerifyPassword(It.IsAny(), It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._userRepositoryMock .Setup(p => p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + .ReturnsAsync(user); string jwtSecurityToken = "akjdhfakndvlahdfkljahdlfkjhasldf"; this._jwtServiceMock @@ -91,7 +91,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); Exception ex = Assert.ThrowsAsync( () => this._userService.LoginUser(loginServiceModel)); @@ -115,10 +115,10 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._userRepositoryMock .Setup(p => p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + .ReturnsAsync(user); Exception ex = Assert.ThrowsAsync(() => this._userService.LoginUser(loginServiceModel)); @@ -144,13 +144,13 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); this._userRepositoryMock .Setup(p => p.VerifyPassword(It.IsAny(), It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._userRepositoryMock .Setup(p => p.DoesEmailExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); this._userRepositoryMock .Setup(p => p.AddAsync(It.IsAny())) .ReturnsAsync(true); @@ -163,10 +163,10 @@ namespace DevHive.Services.Tests this._roleRepositoryMock .Setup(p => p.DoesNameExist(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._roleRepositoryMock .Setup(p => p.GetByNameAsync(It.IsAny())) - .Returns(Task.FromResult(role)); + .ReturnsAsync(role); this._mapperMock .Setup(p => p.Map(It.IsAny())) @@ -189,7 +189,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); Exception ex = Assert.ThrowsAsync( () => this._userService.RegisterUser(registerServiceModel)); @@ -204,10 +204,10 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); this._userRepositoryMock .Setup(p => p.DoesEmailExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); Exception ex = Assert.ThrowsAsync(() => this._userService.RegisterUser(registerServiceModel)); @@ -229,7 +229,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.GetByIdAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + .ReturnsAsync(user); this._mapperMock .Setup(p => p.Map(It.IsAny())) .Returns(userServiceModel); @@ -266,7 +266,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.GetByUsernameAsync(It.IsAny())) - .Returns(Task.FromResult(user)); + .ReturnsAsync(user); this._mapperMock .Setup(p => p.Map(It.IsAny())) .Returns(userServiceModel); @@ -316,19 +316,19 @@ namespace DevHive.Services.Tests // // this._userRepositoryMock.Setup(p => // p.DoesUserExistAsync(It.IsAny())) - // .Returns(Task.FromResult(true)); + // .ReturnsAsync(true); // this._userRepositoryMock.Setup(p => // p.DoesUsernameExistAsync(It.IsAny())) - // .Returns(Task.FromResult(false)); + // .ReturnsAsync(false); // this._userRepositoryMock.Setup(p => // p.DoesUserHaveThisUsernameAsync(It.IsAny(), It.IsAny())) // .Returns(true); // this._userRepositoryMock.Setup(p => // p.EditAsync(It.IsAny(), It.IsAny())) - // .Returns(Task.FromResult(shouldPass)); + // .ReturnsAsync(shouldPass); // this._userRepositoryMock.Setup(p => // p.GetByIdAsync(It.IsAny())) - // .Returns(Task.FromResult(user)); + // .ReturnsAsync(user); // this._mapperMock.Setup(p => // p.Map(It.IsAny())) // .Returns(user); @@ -346,7 +346,7 @@ namespace DevHive.Services.Tests // { // const string EXCEPTION_MESSAGE = "Unable to edit user!"; // - // Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel)); + // Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel); // // Assert.AreEqual(EXCEPTION_MESSAGE, ex.Message, "Incorrect exception message"); // } @@ -359,7 +359,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel)); @@ -373,10 +373,10 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); this._userRepositoryMock .Setup(p => p.DoesUsernameExistAsync(It.IsAny())) - .Returns(Task.FromResult(true)); + .ReturnsAsync(true); Exception ex = Assert.ThrowsAsync(() => this._userService.UpdateUser(updateUserServiceModel)); @@ -396,13 +396,13 @@ namespace DevHive.Services.Tests // // this._userRepositoryMock.Setup(p => // p.DoesUserExistAsync(It.IsAny())) - // .Returns(Task.FromResult(true)); + // .ReturnsAsync(true); // this._userRepositoryMock.Setup(p => // p.GetByIdAsync(It.IsAny())) - // .Returns(Task.FromResult(user)); + // .ReturnsAsync(user); // this._userRepositoryMock.Setup(p => // p.DeleteAsync(It.IsAny())) - // .Returns(Task.FromResult(shouldPass)); + // .ReturnsAsync(shouldPass); // // bool result = await this._userService.DeleteUser(id); // @@ -417,7 +417,7 @@ namespace DevHive.Services.Tests this._userRepositoryMock .Setup(p => p.DoesUserExistAsync(It.IsAny())) - .Returns(Task.FromResult(false)); + .ReturnsAsync(false); Exception ex = Assert.ThrowsAsync(() => this._userService.DeleteUser(id)); -- cgit v1.2.3