From b13e1d473dc1c29925bd37db4c7265bb4dee350b Mon Sep 17 00:00:00 2001 From: Danail Dimitrov Date: Thu, 28 Jan 2021 17:09:36 +0200 Subject: Adding FeedService tests and fixed minor bug with FeedService.GetPage where no exception would be thrown when there are no posts to query --- src/DevHive.Services/Services/FeedService.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/DevHive.Services') diff --git a/src/DevHive.Services/Services/FeedService.cs b/src/DevHive.Services/Services/FeedService.cs index cae986f..5f2410d 100644 --- a/src/DevHive.Services/Services/FeedService.cs +++ b/src/DevHive.Services/Services/FeedService.cs @@ -30,12 +30,14 @@ namespace DevHive.Services.Services throw new ArgumentException("User doesn't exist!"); List friendsList = user.Friends.ToList(); - // if(friendsList.Count == 0) - // throw new ArgumentException("This user does not have any friends!"); + if (friendsList.Count == 0) + throw new ArgumentException("User has no friends to get feed from!"); List posts = await this._feedRepository - .GetFriendsPosts(friendsList, model.FirstRequestIssued, model.PageNumber, model.PageSize) ?? - throw new ArgumentException("No posts to query."); + .GetFriendsPosts(friendsList, model.FirstRequestIssued, model.PageNumber, model.PageSize); + + if (posts.Count <= 0) + throw new ArgumentException("No friends of user have posted anything yet!"); ReadPageServiceModel readPageServiceModel = new(); foreach (Post post in posts) -- cgit v1.2.3