Tryed implementing the http patch

7 files changed, 69 insertions, 49 deletions

diff --git a/src/DevHive.Services/Configurations/Mapping/RoleMapings.cs b/src/DevHive.Services/Configurations/Mapping/RoleMapings.cs
index 4ddd253..b5541f9 100644
--- a/src/DevHive.Services/Configurations/Mapping/RoleMapings.cs
+++ b/src/DevHive.Services/Configurations/Mapping/RoleMapings.cs
@@ -9,6 +9,9 @@ namespace DevHive.Services.Configurations.Mapping
 		public RoleMappings()
 		{
 			CreateMap<RoleServiceModel, Role>();
+			CreateMap<UpdateRoleServiceModel, Role>();
+
+			CreateMap<Role, RoleServiceModel>();
 			CreateMap<Role, RoleServiceModel>();
 		}
 	}
diff --git a/src/DevHive.Services/Configurations/Mapping/UserCollectionMappings.cs b/src/DevHive.Services/Configurations/Mapping/UserCollectionMappings.cs
index ee505a2..7a773e8 100644
--- a/src/DevHive.Services/Configurations/Mapping/UserCollectionMappings.cs
+++ b/src/DevHive.Services/Configurations/Mapping/UserCollectionMappings.cs
@@ -8,14 +8,15 @@ namespace DevHive.Services.Configurations.Mapping
 	{
 		public UserCollectionMappings()
 		{
-			CreateMap<UpdateUserCollectionServiceModel, User>()
-				.ForMember(up => up.UserName, u => u.MapFrom(src => src.Name));
-			CreateMap<UpdateUserCollectionServiceModel, Role>()
-				.ForMember(r => r.Name, u => u.MapFrom(src => src.Name));
-			CreateMap<UpdateUserCollectionServiceModel, Language>()
-				.ForMember(r => r.Name, u => u.MapFrom(src => src.Name));
-			CreateMap<UpdateUserCollectionServiceModel, Technology>()
-				.ForMember(r => r.Name, u => u.MapFrom(src => src.Name));
+			CreateMap<UpdateUserCollectionServiceModel, User>();
+			CreateMap<UpdateUserCollectionServiceModel, Role>();
+			CreateMap<UpdateUserCollectionServiceModel, Language>();
+			CreateMap<UpdateUserCollectionServiceModel, Technology>();
+
+			CreateMap<User, UpdateUserCollectionServiceModel>();
+			CreateMap<Role, UpdateUserCollectionServiceModel>();
+			CreateMap<Language, UpdateUserCollectionServiceModel>();
+			CreateMap<Technology, UpdateUserCollectionServiceModel>();
 		}
 	}
 }
diff --git a/src/DevHive.Services/Configurations/Mapping/UserMappings.cs b/src/DevHive.Services/Configurations/Mapping/UserMappings.cs
index 541e16e..5d9e41c 100644
--- a/src/DevHive.Services/Configurations/Mapping/UserMappings.cs
+++ b/src/DevHive.Services/Configurations/Mapping/UserMappings.cs
@@ -1,6 +1,7 @@
 using DevHive.Data.Models;
 using AutoMapper;
 using DevHive.Services.Models.Identity.User;
+using DevHive.Common.Models.Misc;
 
 namespace DevHive.Services.Configurations.Mapping
 {
@@ -10,10 +11,13 @@ namespace DevHive.Services.Configurations.Mapping
 		{
 			CreateMap<UserServiceModel, User>();
 			CreateMap<RegisterServiceModel, User>();
-			CreateMap<UpdateUserServiceModel, User>();
+			CreateMap<UpdateUserServiceModel, User>()
+				.AfterMap((src, dest) => dest.PasswordHash = PasswordModifications.GeneratePasswordHash(src.Password));
 			CreateMap<FriendServiceModel, User>();
 
 			CreateMap<User, UserServiceModel>();
+			CreateMap<User, UpdateUserServiceModel>()
+				.ForMember(x => x.Password, opt => opt.Ignore());
 			CreateMap<User, FriendServiceModel>();
 		}
 	}
diff --git a/src/DevHive.Services/Interfaces/IUserService.cs b/src/DevHive.Services/Interfaces/IUserService.cs
index 121fec3..88be0c8 100644
--- a/src/DevHive.Services/Interfaces/IUserService.cs
+++ b/src/DevHive.Services/Interfaces/IUserService.cs
@@ -1,9 +1,9 @@
 using System;
+using System.Collections.Generic;
 using System.Threading.Tasks;
 using DevHive.Common.Models.Identity;
-using DevHive.Data.Models;
+using DevHive.Common.Models.Misc;
 using DevHive.Services.Models.Identity.User;
-using Microsoft.AspNetCore.JsonPatch;
 
 namespace DevHive.Services.Interfaces
 {
@@ -18,7 +18,7 @@ namespace DevHive.Services.Interfaces
 		Task<UserServiceModel> GetUserById(Guid id);
 
 		Task<UserServiceModel> UpdateUser(UpdateUserServiceModel updateModel);
-		Task<UserServiceModel> PatchUser(Guid id, JsonPatchDocument<User> jsonPatch);
+		Task<UserServiceModel> PatchUser(Guid id, List<Patch> patch);
 
 		Task DeleteUser(Guid id);
 		Task<bool> RemoveFriend(Guid userId, Guid friendId);
diff --git a/src/DevHive.Services/Models/Identity/User/BaseUserServiceModel.cs b/src/DevHive.Services/Models/Identity/User/BaseUserServiceModel.cs
index 514f82a..7a160f8 100644
--- a/src/DevHive.Services/Models/Identity/User/BaseUserServiceModel.cs
+++ b/src/DevHive.Services/Models/Identity/User/BaseUserServiceModel.cs
@@ -6,5 +6,6 @@ namespace DevHive.Services.Models.Identity.User
 		public string Email { get; set; }
 		public string FirstName { get; set; }
 		public string LastName { get; set; }
+		public string Password { get; set; }
 	}
 }
diff --git a/src/DevHive.Services/Models/Technology/ReadTechnologyServiceModel.cs b/src/DevHive.Services/Models/Technology/ReadTechnologyServiceModel.cs
new file mode 100644
index 0000000..cbfdc7d
--- /dev/null
+++ b/src/DevHive.Services/Models/Technology/ReadTechnologyServiceModel.cs
@@ -0,0 +1,7 @@
+namespace DevHive.Services.Models.Technology
+{
+	public class ReadTechnologyServiceModel
+	{
+		public string Name { get; set; }
+	}
+}
diff --git a/src/DevHive.Services/Services/UserService.cs b/src/DevHive.Services/Services/UserService.cs
index 51c4432..629b489 100644
--- a/src/DevHive.Services/Services/UserService.cs
+++ b/src/DevHive.Services/Services/UserService.cs
@@ -7,15 +7,14 @@ using System;
 using System.IdentityModel.Tokens.Jwt;
 using System.Security.Claims;
 using Microsoft.IdentityModel.Tokens;
-using System.Security.Cryptography;
 using System.Text;
 using System.Collections.Generic;
 using DevHive.Common.Models.Identity;
 using DevHive.Services.Interfaces;
 using DevHive.Data.Interfaces.Repositories;
-using Microsoft.AspNetCore.JsonPatch;
 using System.Linq;
-using Newtonsoft.Json;
+using DevHive.Common.Models.Misc;
+using System.Reflection;
 
 namespace DevHive.Services.Services
 {
@@ -52,7 +51,7 @@ namespace DevHive.Services.Services
 
 			User user = await this._userRepository.GetByUsernameAsync(loginModel.UserName);
 
-			if (user.PasswordHash != GeneratePasswordHash(loginModel.Password))
+			if (user.PasswordHash != PasswordModifications.GeneratePasswordHash(loginModel.Password))
 				throw new ArgumentException("Incorrect password!");
 
 			return new TokenModel(WriteJWTSecurityToken(user.Id, user.Roles));
@@ -67,7 +66,7 @@ namespace DevHive.Services.Services
 				throw new ArgumentException("Email already exists!");
 
 			User user = this._userMapper.Map<User>(registerModel);
-			user.PasswordHash = GeneratePasswordHash(registerModel.Password);
+			user.PasswordHash = PasswordModifications.GeneratePasswordHash(registerModel.Password);
 
 			// Make sure the default role exists
 			if (!await this._roleRepository.DoesNameExist(Role.DefaultRole))
@@ -135,6 +134,7 @@ namespace DevHive.Services.Services
 
 		public async Task<UserServiceModel> UpdateUser(UpdateUserServiceModel updateUserServiceModel)
 		{
+			//Method: ValidateUserOnUpdate
 			if (!await this._userRepository.DoesUserExistAsync(updateUserServiceModel.Id))
 				throw new ArgumentException("User does not exist!");
 
@@ -144,6 +144,7 @@ namespace DevHive.Services.Services
 
 			await this.ValidateUserCollections(updateUserServiceModel);
 
+			//Method: Insert collections to user
 			HashSet<Language> languages = new();
 			foreach (UpdateUserCollectionServiceModel lang in updateUserServiceModel.Languages)
 				languages.Add(await this._languageRepository.GetByNameAsync(lang.Name) ??
@@ -159,51 +160,35 @@ namespace DevHive.Services.Services
 			user.Languages = languages;
 			user.Technologies = technologies;
 
-			bool success = await this._userRepository.EditAsync(user);
+			bool successful = await this._userRepository.EditAsync(user);
 
-			if (!success)
+			if (!successful)
 				throw new InvalidOperationException("Unable to edit user!");
 
 			return this._userMapper.Map<UserServiceModel>(user); ;
 		}
 
-		public async Task<UserServiceModel> PatchUser(Guid id, JsonPatchDocument<User> jsonPatch)
+		public async Task<UserServiceModel> PatchUser(Guid id, List<Patch> patchList)
 		{
 			User user = await this._userRepository.GetByIdAsync(id) ??
 				throw new ArgumentException("User does not exist!");
 
-			object password = jsonPatch.Operations
-				.Where(x => x.path == "/password")
-				.Select(x => x.value)
-				.FirstOrDefault();
-
-			IEnumerable<object> friends = jsonPatch.Operations
-				.Where(x => x.path == "/friends")
-				.Select(x => x.value);
-
-			if(password != null)
-			{
-				string passwordHash = this.GeneratePasswordHash(password.ToString());
-				user.PasswordHash = passwordHash;
-			}
+			UpdateUserServiceModel updateUserServiceModel = this._userMapper.Map<UpdateUserServiceModel>(user);
 
-			if (friends != null)
+			foreach (Patch patch in patchList)
 			{
-				foreach (object friendObj in friends)
+				bool successful = patch.Action switch
 				{
-					FriendServiceModel friendServiceModel =
-						JsonConvert.DeserializeObject<FriendServiceModel>(friendObj.ToString());
-
-					User amigo = await this._userRepository.GetByUsernameAsync(friendServiceModel.UserName)
-						?? throw new ArgumentException($"User {friendServiceModel.UserName} does not exist!");
-
-					user.Friends.Add(amigo);
-				}
+					"replace" => ReplacePatch(updateUserServiceModel, patch),
+					"add" => AddPatch(updateUserServiceModel, patch),
+					"remove" => RemovePatch(updateUserServiceModel, patch),
+					_ => throw new ArgumentException("Invalid patch operation!"),
+				};
+
+				if (!successful)
+					throw new ArgumentException("A problem occurred while applying patch");
 			}
 
-			//Remove password and friends peace from the request patch before applying the rest
-			// jsonPatch.ApplyTo(user);
-
 			bool success = await this._userRepository.EditAsync(user);
 			if (success)
 			{
@@ -326,6 +311,11 @@ namespace DevHive.Services.Services
 			}
 		}
 
+		private async Task ValidateUserOnUpdate(UpdateUserServiceModel updateUserServiceModel)
+		{
+
+		}
+
 		private string WriteJWTSecurityToken(Guid userId, HashSet<Role> roles)
 		{
 			byte[] signingKey = Encoding.ASCII.GetBytes(_jwtOptions.Secret);
@@ -354,9 +344,23 @@ namespace DevHive.Services.Services
 			return tokenHandler.WriteToken(token);
 		}
 
-		private string GeneratePasswordHash(string password)
+		private bool AddPatch(UpdateUserServiceModel updateUserServiceModel, Patch patch)
+		{
+			// Type type = typeof(UpdateUserServiceModel);
+			// PropertyInfo property = type.GetProperty(patch.Name);
+
+			// property.SetValue(updateUserServiceModel, patch.Value);
+			throw new NotImplementedException();
+		}
+
+		private bool RemovePatch(UpdateUserServiceModel updateUserServiceModel, Patch patch)
+		{
+			throw new NotImplementedException();
+		}
+
+		private bool ReplacePatch(UpdateUserServiceModel updateUserServiceModel, Patch patch)
 		{
-			return string.Join(string.Empty, SHA512.HashData(Encoding.ASCII.GetBytes(password)));
+			throw new NotImplementedException();
 		}
 		#endregion
 	}