Merge pull request #21 from Team-Kaleidoscope/unit_test_refactoring

Unit test code style refactor

1 files changed, 19 insertions, 19 deletions

diff --git a/src/Data/DevHive.Data.Tests/LenguageRepository.Tests.cs b/src/Data/DevHive.Data.Tests/LenguageRepository.Tests.cs
index f02a1e4..3bb9400 100644
--- a/src/Data/DevHive.Data.Tests/LenguageRepository.Tests.cs
+++ b/src/Data/DevHive.Data.Tests/LenguageRepository.Tests.cs
@@ -12,25 +12,25 @@ namespace DevHive.Data.Tests
 	public class LenguageRepositoryTests
 	{
 		private const string LANGUAGE_NAME = "Language test name";
-		protected DevHiveContext Context { get; set; }
-		protected LanguageRepository LanguageRepository { get; set; }
+		private DevHiveContext _context;
+		private LanguageRepository _languageRepository;
 
 		#region Setups
 		[SetUp]
 		public void Setup()
 		{
-			var optionsBuilder = new DbContextOptionsBuilder<DevHiveContext>()
+			DbContextOptionsBuilder<DevHiveContext> optionsBuilder = new DbContextOptionsBuilder<DevHiveContext>()
 				.UseInMemoryDatabase(databaseName: "DevHive_Test_Database");
 
-			this.Context = new DevHiveContext(optionsBuilder.Options);
+			this._context = new DevHiveContext(optionsBuilder.Options);
 
-			LanguageRepository = new LanguageRepository(Context);
+			this._languageRepository = new LanguageRepository(this._context);
 		}
 
 		[TearDown]
 		public void TearDown()
 		{
-			this.Context.Database.EnsureDeleted();
+			this._context.Database.EnsureDeleted();
 		}
 		#endregion
 
@@ -38,11 +38,11 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task GetByNameAsync_ReturnsTheCorrectLanguage_IfItExists()
 		{
-			await AddEntity();
+			await this.AddEntity();
 
-			Language language = this.Context.Languages.Where(x => x.Name == LANGUAGE_NAME).ToList().FirstOrDefault();
+			Language language = this._context.Languages.Where(x => x.Name == LANGUAGE_NAME).AsEnumerable().FirstOrDefault();
 
-			Language languageResult = await this.LanguageRepository.GetByNameAsync(LANGUAGE_NAME);
+			Language languageResult = await this._languageRepository.GetByNameAsync(LANGUAGE_NAME);
 
 			Assert.AreEqual(language.Id, languageResult.Id);
 		}
@@ -50,7 +50,7 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task GetByNameAsync_ReturnsNull_IfTechnologyDoesNotExists()
 		{
-			Language languageResult = await this.LanguageRepository.GetByNameAsync(LANGUAGE_NAME);
+			Language languageResult = await this._languageRepository.GetByNameAsync(LANGUAGE_NAME);
 
 			Assert.IsNull(languageResult);
 		}
@@ -60,12 +60,12 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task DoesLanguageExist_ReturnsTrue_IfIdExists()
 		{
-			await AddEntity();
-			Language language = this.Context.Languages.Where(x => x.Name == LANGUAGE_NAME).ToList().FirstOrDefault();
+			await this.AddEntity();
+			Language language = this._context.Languages.Where(x => x.Name == LANGUAGE_NAME).AsEnumerable().FirstOrDefault();
 
 			Guid id = language.Id;
 
-			bool result = await this.LanguageRepository.DoesLanguageExistAsync(id);
+			bool result = await this._languageRepository.DoesLanguageExistAsync(id);
 
 			Assert.IsTrue(result, "DoesLanguageExistAsync returns flase when language exists");
 		}
@@ -75,7 +75,7 @@ namespace DevHive.Data.Tests
 		{
 			Guid id = Guid.NewGuid();
 
-			bool result = await this.LanguageRepository.DoesLanguageExistAsync(id);
+			bool result = await this._languageRepository.DoesLanguageExistAsync(id);
 
 			Assert.IsFalse(result, "DoesLanguageExistAsync returns true when language does not exist");
 		}
@@ -85,9 +85,9 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task DoesLanguageNameExist_ReturnsTrue_IfLanguageExists()
 		{
-			await AddEntity();
+			await this.AddEntity();
 
-			bool result = await this.LanguageRepository.DoesLanguageNameExistAsync(LANGUAGE_NAME);
+			bool result = await this._languageRepository.DoesLanguageNameExistAsync(LANGUAGE_NAME);
 
 			Assert.IsTrue(result, "DoesLanguageNameExists returns true when language name does not exist");
 		}
@@ -95,7 +95,7 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task DoesLanguageNameExist_ReturnsFalse_IfLanguageDoesNotExists()
 		{
-			bool result = await this.LanguageRepository.DoesLanguageNameExistAsync(LANGUAGE_NAME);
+			bool result = await this._languageRepository.DoesLanguageNameExistAsync(LANGUAGE_NAME);
 
 			Assert.False(result, "DoesTechnologyNameExistAsync returns true when language name does not exist");
 		}
@@ -104,12 +104,12 @@ namespace DevHive.Data.Tests
 		#region HelperMethods
 		private async Task AddEntity(string name = LANGUAGE_NAME)
 		{
-			Language language = new Language
+			Language language = new()
 			{
 				Name = name
 			};
 
-			await this.LanguageRepository.AddAsync(language);
+			await this._languageRepository.AddAsync(language);
 		}
 		#endregion
 	}