Merge pull request #21 from Team-Kaleidoscope/unit_test_refactoring

Unit test code style refactor

1 files changed, 21 insertions, 39 deletions

diff --git a/src/Data/DevHive.Data.Tests/FeedRepository.Tests.cs b/src/Data/DevHive.Data.Tests/FeedRepository.Tests.cs
index f134bf3..f54e89d 100644
--- a/src/Data/DevHive.Data.Tests/FeedRepository.Tests.cs
+++ b/src/Data/DevHive.Data.Tests/FeedRepository.Tests.cs
@@ -11,26 +11,25 @@ namespace DevHive.Data.Tests
 	[TestFixture]
 	public class FeedRepositoryTests
 	{
-		protected DevHiveContext Context { get; set; }
-
-		protected FeedRepository FeedRepository { get; set; }
+		private DevHiveContext _context;
+		private FeedRepository _feedRepository;
 
 		#region Setups
 		[SetUp]
 		public void Setup()
 		{
-			var optionsBuilder = new DbContextOptionsBuilder<DevHiveContext>()
+			DbContextOptionsBuilder<DevHiveContext> optionsBuilder = new DbContextOptionsBuilder<DevHiveContext>()
 				.UseInMemoryDatabase(databaseName: "DevHive_Test_Database");
 
-			this.Context = new DevHiveContext(optionsBuilder.Options);
+			this._context = new DevHiveContext(optionsBuilder.Options);
 
-			FeedRepository = new FeedRepository(Context);
+			this._feedRepository = new FeedRepository(this._context);
 		}
 
 		[TearDown]
 		public void TearDown()
 		{
-			this.Context.Database.EnsureDeleted();
+			this._context.Database.EnsureDeleted();
 		}
 		#endregion
 
@@ -38,20 +37,19 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task GetFriendsPosts_ReturnsListOfPosts_WhenTheyExist()
 		{
-			User dummyUser = this.CreateDummyUser();
-			List<User> friendsList = new List<User>();
-			friendsList.Add(dummyUser);
+			User dummyUser = CreateDummyUser();
+			List<User> friendsList = new()
+			{
+				dummyUser
+			};
 
-			DateTime dateTime = new DateTime(3000, 05, 09, 9, 15, 0);
+			DateTime dateTime = new(3000, 05, 09, 9, 15, 0);
 			Console.WriteLine(dateTime.ToFileTime());
 
-			Post dummyPost = this.CreateDummyPost(dummyUser);
-			Post anotherDummnyPost = this.CreateDummyPost(dummyUser);
-
 			const int PAGE_NUMBER = 1;
 			const int PAGE_SIZE = 10;
 
-			List<Post> resultList = await this.FeedRepository.GetFriendsPosts(friendsList, dateTime, PAGE_NUMBER, PAGE_SIZE);
+			List<Post> resultList = await this._feedRepository.GetFriendsPosts(friendsList, dateTime, PAGE_NUMBER, PAGE_SIZE);
 
 			Assert.GreaterOrEqual(2, resultList.Count, "GetFriendsPosts does not return all correct posts");
 		}
@@ -59,23 +57,25 @@ namespace DevHive.Data.Tests
 		[Test]
 		public async Task GetFriendsPosts_ReturnsNull_WhenNoSuitablePostsExist()
 		{
-			User dummyUser = this.CreateDummyUser();
-			List<User> friendsList = new List<User>();
-			friendsList.Add(dummyUser);
+			User dummyUser = CreateDummyUser();
+			List<User> friendsList = new()
+			{
+				dummyUser
+			};
 
-			DateTime dateTime = new DateTime(3000, 05, 09, 9, 15, 0);
+			DateTime dateTime = new(3000, 05, 09, 9, 15, 0);
 
 			const int PAGE_NUMBER = 1;
 			const int PAGE_SIZE = 10;
 
-			List<Post> resultList = await this.FeedRepository.GetFriendsPosts(friendsList, dateTime, PAGE_NUMBER, PAGE_SIZE);
+			List<Post> resultList = await this._feedRepository.GetFriendsPosts(friendsList, dateTime, PAGE_NUMBER, PAGE_SIZE);
 
 			Assert.LessOrEqual(0, resultList.Count, "GetFriendsPosts does not return all correct posts");
 		}
 		#endregion
 
 		#region HelperMethods
-		private User CreateDummyUser()
+		private static User CreateDummyUser()
 		{
 			HashSet<Role> roles = new()
 			{
@@ -96,24 +96,6 @@ namespace DevHive.Data.Tests
 				Roles = roles
 			};
 		}
-
-		private Post CreateDummyPost(User poster)
-		{
-			const string POST_MESSAGE = "random message";
-			Guid id = Guid.NewGuid();
-			Post post = new Post
-			{
-				Id = id,
-				Message = POST_MESSAGE,
-				Creator = poster,
-				TimeCreated = new DateTime(2000, 05, 09, 9, 15, 0)
-			};
-
-			this.Context.Posts.Add(post);
-			this.Context.SaveChanges();
-
-			return post;
-		}
 		#endregion
 	}
 }