From 1f47d1276217474d553d8b65dd64ac72f92f8a3e Mon Sep 17 00:00:00 2001 From: Syndamia Date: Mon, 8 Jan 2024 17:54:12 +0200 Subject: [src] Fixed angled bracket includes to quote includes where applicable --- src/server-cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/server-cli.c') diff --git a/src/server-cli.c b/src/server-cli.c index 707c3ef..5e84ff6 100644 --- a/src/server-cli.c +++ b/src/server-cli.c @@ -1,5 +1,5 @@ -#include -#include +#include "util.h" +#include "server-connection.h" #include #include #include -- cgit v1.2.3 From 4c3debc36ceaa7bc4857f61099e78de3b4e044b5 Mon Sep 17 00:00:00 2001 From: Syndamia Date: Mon, 8 Jan 2024 19:01:10 +0200 Subject: [browser-cli,server-cli] Fixed security issues --- src/browser-cli.c | 4 ++-- src/server-cli.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/server-cli.c') diff --git a/src/browser-cli.c b/src/browser-cli.c index 75a2374..1b2b446 100644 --- a/src/browser-cli.c +++ b/src/browser-cli.c @@ -59,7 +59,7 @@ void renderPage(const sds page) { /* In toPrint, replace '\16' with "\033[30;46m%d\033[0m", where %d is the variable i */ toPrint[anchorInd] = '\0'; newPrint = sdsgrowzero(sdsempty(), sdslen(toPrint) + digits(i) + 8 + 4); - sprintf(newPrint, "%s\033[30;46m%d\033[0m%s", toPrint, i, toPrint + anchorInd + 1); + snprintf(newPrint, sdslen(newPrint), "%s\033[30;46m%d\033[0m%s", toPrint, i, toPrint + anchorInd + 1); sdsfree(toPrint); toPrint = newPrint; @@ -172,7 +172,7 @@ int handleBrowserCLI(sds *host, sds *port, sds *uri, const sds page) { // Get command name and it's arguments // Currently no command takes arguments char name[MAX_LEN_COMMAND+1] = { '\0' }; - int argsAssigned = sscanf(line, COMMAND_FORMAT, name); + sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore if (streq(name, "q") || streq(name, "e") || streq(name, "quit") || streq(name, "exit")) { return 1; diff --git a/src/server-cli.c b/src/server-cli.c index 5e84ff6..8d6b3ee 100644 --- a/src/server-cli.c +++ b/src/server-cli.c @@ -21,7 +21,7 @@ void handleCLI(sds **vhosts, int vhostsc) { // Get command name and it's arguments // Currently no command takes arguments char name[MAX_LEN_COMMAND+1]; - int argsAssigned = sscanf(line, COMMAND_FORMAT, name); + int argsAssigned = sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore while (!streq(name, "q") && !streq(name, "e") && !streq(name, "quit") && !streq(name, "exit")) { if (argsAssigned < 1) { @@ -44,7 +44,7 @@ void handleCLI(sds **vhosts, int vhostsc) { // Get line and divided it into command name and arguments fgets(line, 256, stdin); - argsAssigned = sscanf(line, COMMAND_FORMAT, name); + argsAssigned = sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore } printf("Exiting...\n"); -- cgit v1.2.3