diff options
| author | Syndamia <kamen@syndamia.com> | 2024-01-08 19:01:10 +0200 |
|---|---|---|
| committer | Syndamia <kamen@syndamia.com> | 2024-01-08 19:01:10 +0200 |
| commit | 4c3debc36ceaa7bc4857f61099e78de3b4e044b5 (patch) | |
| tree | a410d738c7efcf367ecf1f088dd746a1702e9c10 | |
| parent | 1f8549106445d97d910fbe209cad0d2657efd97a (diff) | |
| download | pico-web-4c3debc36ceaa7bc4857f61099e78de3b4e044b5.tar pico-web-4c3debc36ceaa7bc4857f61099e78de3b4e044b5.tar.gz pico-web-4c3debc36ceaa7bc4857f61099e78de3b4e044b5.zip | |
[browser-cli,server-cli] Fixed security issues
| -rw-r--r-- | src/browser-cli.c | 4 | ||||
| -rw-r--r-- | src/server-cli.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/browser-cli.c b/src/browser-cli.c index 75a2374..1b2b446 100644 --- a/src/browser-cli.c +++ b/src/browser-cli.c @@ -59,7 +59,7 @@ void renderPage(const sds page) { /* In toPrint, replace '\16' with "\033[30;46m%d\033[0m", where %d is the variable i */ toPrint[anchorInd] = '\0'; newPrint = sdsgrowzero(sdsempty(), sdslen(toPrint) + digits(i) + 8 + 4); - sprintf(newPrint, "%s\033[30;46m%d\033[0m%s", toPrint, i, toPrint + anchorInd + 1); + snprintf(newPrint, sdslen(newPrint), "%s\033[30;46m%d\033[0m%s", toPrint, i, toPrint + anchorInd + 1); sdsfree(toPrint); toPrint = newPrint; @@ -172,7 +172,7 @@ int handleBrowserCLI(sds *host, sds *port, sds *uri, const sds page) { // Get command name and it's arguments // Currently no command takes arguments char name[MAX_LEN_COMMAND+1] = { '\0' }; - int argsAssigned = sscanf(line, COMMAND_FORMAT, name); + sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore if (streq(name, "q") || streq(name, "e") || streq(name, "quit") || streq(name, "exit")) { return 1; diff --git a/src/server-cli.c b/src/server-cli.c index 5e84ff6..8d6b3ee 100644 --- a/src/server-cli.c +++ b/src/server-cli.c @@ -21,7 +21,7 @@ void handleCLI(sds **vhosts, int vhostsc) { // Get command name and it's arguments // Currently no command takes arguments char name[MAX_LEN_COMMAND+1]; - int argsAssigned = sscanf(line, COMMAND_FORMAT, name); + int argsAssigned = sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore while (!streq(name, "q") && !streq(name, "e") && !streq(name, "quit") && !streq(name, "exit")) { if (argsAssigned < 1) { @@ -44,7 +44,7 @@ void handleCLI(sds **vhosts, int vhostsc) { // Get line and divided it into command name and arguments fgets(line, 256, stdin); - argsAssigned = sscanf(line, COMMAND_FORMAT, name); + argsAssigned = sscanf(line, COMMAND_FORMAT, name); // Flawfinder: ignore } printf("Exiting...\n"); |